Re: [PATCH v2 4/8] metaperf: Include linux/param.h explicitly for HZ macro

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sat, Jan 27, 2018 at 02:16:59PM +1100, Dave Chinner wrote:
> On Wed, Jan 24, 2018 at 11:58:59AM +0800, Eryu Guan wrote:
> > On Mon, Jan 22, 2018 at 12:24:06PM -0800, Christoph Hellwig wrote:
> > > On Mon, Jan 22, 2018 at 03:57:15PM +0000, Rostislav Skudnov wrote:
> > > > Glibc includes linux/param.h when we include sys/param.h, whereas musl
> > > > libc does not do that. HZ is a Linux-specific macro, therefore include
> > > > the header file that defines it explicitly.
> > > > 
> > > > Signed-off-by: Rostislav Skudnov <rostislav@xxxxxxxxxx>
> > > 
> > > Using HZ in userspace doesn't make any sense at all.  The kernel HZ
> > > (as in the granulairy for jiffies) can vary between architectures
> > > and even configurations.  I guess it wants a hard coded 100 here, but
> > > someone will have to do a detailed analysis.
> > 
> > No one is using metaperf now, all the old benchmark infrastructure was
> > removed by commit b020416d51ff ("xfstests: remove bench infrastructure")
> > 
> > I think we can remove src/metaperf.c too.
> 
> FYI I use dirperf and metaperf for standalone ismoke testing of my
> kernel changes quite a lot...

Sorry for the duplicate response, I thought it had been lost and
hadn't realised the mail queue on my laptop had got stuck a couple
of days ago...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux