Re: [PATCH 3/4] holetest: Fix comparison of unsigned integer with 0

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Oct 05, 2017 at 12:49:59PM +0000, Rostislav Skudnov wrote:
> ---
>  src/holetest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/holetest.c b/src/holetest.c
> index 1939b35..e7ba123 100644
> --- a/src/holetest.c
> +++ b/src/holetest.c
> @@ -205,7 +205,7 @@ int test_this(int fd, loff_t sz)
>  			 */
>  			fflush(stdout);
>  			tid[i] = fork();
> -			if (tid[i] < 0) {
> +			if ((int64_t)tid[i] < 0) {

Just use the proper type for the return.  But I think this whole
file needs a redo - it tries to use tid both for storing a fork
return value and a pthread_t pointer.  If you only want a minimal
fix just introduce a int ret local variable.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux