Re: [PATCH 4/4] bulkstat_unlink_test_modified: Remove extraneous if statement

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



> bulkstat_unlink_test_modified.c:171:26: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
>                     if ((ret[i].bs_ino == inodelist[j])) {

Which the patch doesn't seem to actually remove..

> -		    if ((ret[i].bs_ino == inodelist[j])) {
> -			if ((genlist[j] + 1) != ret[i].bs_gen) {

module any reindentation this should be:

		if (ret[i].bs_ino == inodelist[j]) {
			if (genlist[j] + 1 != ret[i].bs_gen) {

alththough merging both conditionals also seems fine to me, as would
putting the ret array on the same side of both, e.g. something like:

		if (ret[i].bs_ino == inodelist[j] &&
		    ret[i].bs_gen != genlist[j]) {
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux