On Fri, 13 Jan 2017 12:24:04 +0800, Eryu Guan wrote: > On Thu, Jan 12, 2017 at 06:18:49PM +0100, David Disseldorp wrote: > > Without any $tmp suffix, users silly enough to run xfstests without > > mktemp present will unintentionally "rm -f *". > > mktemp creates a file too, removing $tmp.xxx files won't remove $tmp > file itself. So along with removing them by name, I'm thinking about > initializing tmp with /tmp/$$._mkfs (or something like that) as well. Oh, yes I missed the extra $tmp rm parameter. > I have another tmp file cleanup patch[1] pending in the list, would you > like to do all the cleanup fix in your patch? Or I can fold your patch > to mine and send out v3. Please fold it into your patchset. Cheers, David -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html