On Thu, 12 Jan 2017 11:51:24 +0800, Eryu Guan wrote:
...
> I noticed that this $_version is only assigned to XFSPROGS_VERSION, and
> the only user of $XFSPROGS_VERSION is xfs/188.
>
> if [ $XFSPROGS_VERSION -lt 21000 ]; then
> _notrun "this test requires case-insensitive support"
> fi
>
> That's a test added in 2008, now we avoid skipping tests by checking on
> some version number, we tend to add new _require rules to actually test
> for the requirements. e.g. for xfs/188, I think we can have:
>
> in common/xfs:
> # this test requires mkfs.xfs have case-insensitive naming support
> _require_xfs_mkfs_ciname()
> {
> _scratch_mkfs_xfs_supported -n version=ci >/dev/null 2>&1 \
> || _notrun "need case-insensitive naming support in mkfs.xfs"
> }
>
> And remove all the version detection & checking code from common/config
> and xfs/188, and call the new _require rule in the test.
This seems much nicer, Eryu. I'm giving it a spin now, and will send a
patch once tested - thanks for the feedback.
Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
