Re: [PATCH] generic: Check linking O_TMPFILE into namespace with POSIX ACLs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sat, Dec 10, 2016 at 01:39:35PM +0800, Eryu Guan wrote:
> On Fri, Dec 09, 2016 at 01:35:36PM -0700, Ross Zwisler wrote:
> > On Wed, Oct 19, 2016 at 5:50 AM, Andreas Gruenbacher
> > <agruenba@xxxxxxxxxx> wrote:
> > >
> > > When an O_TMPFILE file is linked into a directory with a POSIX default
> > > ACL, the file should inherit the default ACL and the umask needs to be
> > > ignored.
> > >
> > > This goes together with generic/004, which tests O_TMPFILE files without
> > > POSIX ACLs.
> > >
> > > Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> > 
> > I can't seem to get this test to pass.  It fails for me with PMEM and
> > BRD devices, and with XFS, ext4 and ext2.
> 
> Probably you need the latest xfsprogs, specifically this patch
> 
> commit 41c702ce4b2bbea59e49384a90e17c64e46bd3ae
> Author: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> Date:   Tue Nov 1 10:38:40 2016 +1100
> 
>     xfs_io: Fix initial -m option
>     
>     Like "open -m mode", the initial -m option requires a mode argument.
>     
>     Document these options correctly as well.
>     
>     Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
>     Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
>     Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
> 

Great, thanks.  I updated my xfsprogs and e2fsprogs and now it's passing for
all 3 filesystems.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux