Re: [PATCH] generic: Check linking O_TMPFILE into namespace with POSIX ACLs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Oct 19, 2016 at 5:50 AM, Andreas Gruenbacher
<agruenba@xxxxxxxxxx> wrote:
>
> When an O_TMPFILE file is linked into a directory with a POSIX default
> ACL, the file should inherit the default ACL and the umask needs to be
> ignored.
>
> This goes together with generic/004, which tests O_TMPFILE files without
> POSIX ACLs.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>

I can't seem to get this test to pass.  It fails for me with PMEM and
BRD devices, and with XFS, ext4 and ext2.

Here is an easily reproducible failure with xfs and two 2GiB BRD ram
disks for the TEST_DEV and SCRATCH_DEV:

# ./check generic/389
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 alara 4.9.0-rc8
MKFS_OPTIONS  -- -f -bsize=4096 /dev/ram1
MOUNT_OPTIONS -- -o context=system_u:object_r:nfs_t:s0 /dev/ram1
/mnt/xfstests_scratch

generic/389 - output mismatch (see /root/xfstests/results//generic/389.out.bad)
    --- tests/generic/389.out 2016-12-09 13:17:21.874927856 -0700
    +++ /root/xfstests/results//generic/389.out.bad 2016-12-09
13:31:22.831911244 -0700
    @@ -1,6 +1,2 @@
     QA output created by 389
    -wrote 4096/4096 bytes at offset 0
    -XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
    -read 4096/4096 bytes at offset 0
    -XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
    -664
    +stat: cannot stat '/mnt/xfstests_test/d.389/tst-tmpfile-flink':
No such file or directory
    ...
    (Run 'diff -u tests/generic/389.out
/root/xfstests/results//generic/389.out.bad'  to see the entire diff)
Ran: generic/389
Failures: generic/389
Failed 1 of 1 tests

This is using vanilla v4.9.0-rc8 and the following xfstests commit:

adcc60c build: allow building with latest xfslibs on 32-bit Linux

Is the test broken?
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux