On 9/20/16 6:40 PM, Dave Chinner wrote:
> On Tue, Sep 20, 2016 at 05:24:59PM -0500, Eric Sandeen wrote:
>> Now that these tests have been made generic, move them into
>> the generic/ dir and update group files.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>
> I wonder if this would be better done simply as a tools/mvtest
> script for the maintainer to run. e.g.
>
> #!/bin/sh
>
> tools/mvtest xfs/054 generic/380
> tools/mvtest xfs/118 generic/381
> tools/mvtest xfs/138 generic/382
> tools/mvtest xfs/260 generic/383
>
> #EOF
>
> Rather than ending up with patch that won't apply because we've
> already applied another patch that added a new test that conflicts?
> Reviewing the change is also heaps easier :)
Oh, yeah. I didn't know that script existed.
...
>>
>> N?????r??y????b?X??ǧv?^?){.n?+?????ȧ???ܨ}???Ơz?&j:+v???????zZ+??+zf???h???~????i???z? ?w?????????&?)ߢf
>
> Ummm, what? That looks like some kind of corruption occurred in
> transit. There's no mailing list footer, and it's not at my end as
> it's in the archive copies, too....
Huh, strange - not sure what to make of that. But I guess the mvtest bit
can make it not matter. ;)
Honestly I don't care where they land, and I don't know what else is in flight;
maybe patch 3 should be "please move these to generic as you see fit?" :)
-Eric
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
