Re: [PATCH 3/3] move now-generic quota tests to generic

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Sep 20, 2016 at 05:24:59PM -0500, Eric Sandeen wrote:
> Now that these tests have been made generic, move them into
> the generic/ dir and update group files.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

I wonder if this would be better done simply as a tools/mvtest
script for the maintainer to run. e.g.

#!/bin/sh

tools/mvtest xfs/054 generic/380
tools/mvtest xfs/118 generic/381
tools/mvtest xfs/138 generic/382
tools/mvtest xfs/260 generic/383

#EOF

Rather than ending up with patch that won't apply because we've
already applied another patch that added a new test that conflicts?
Reviewing the change is also heaps easier :)

> ---
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index a602b01..f5ebbb1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -381,3 +381,8 @@
>  376 auto quick metadata
>  377 attr auto quick metadata
>  378 auto quick metadata
> +380 quota auto quick
> +381 quota auto quick
> +382 auto quick quota
> +383 auto quick quota
> +

No trailing blank line....

> @@ -257,7 +254,6 @@
>  257 auto quick clone
>  258 auto quick clone
>  259 auto quick
> -260 auto quick quota
>  261 auto quick quota
>  262 auto quick quota
>  263 auto quick quota
> 
> N?????r??y????b?X??ǧv?^?)޺{.n?+????׬?ȧ???ܨ}???Ơz?&j:+v???????zZ+??+zf???h???~????i???z??w?????????&?)ߢf

Ummm, what? That looks like some kind of corruption occurred in
transit. There's no mailing list footer, and it's not at my end as
it's in the archive copies, too....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux