On Wed, May 18, 2016 at 12:40:54PM -0500, Jeffrey Bastian wrote: > Linux kernel v4.5 defines 'struct fsxattr' in linux/fs.h [0] but it's > still defined in xfs/linux.h as a backup [1]. If the files are included > in the wrong order, the compiler will complain with a redefinition > error. This patch moves linux/fs.h (and linux/magic.h) before the xfs > headers for the t_immutable.c and fsstress.c tests. This patch _may_ not be necessary; this is also being discussed on the xfs list and including linux/fs.h in xfsprogs' include/linux.h solves the problem, i.e., the include order won't matter. On the other hand, it seems to be best-practice (if not a hard-and-fast rule) to include fs.h first, so maybe the patch should be applied to xfstests anyway? http://oss.sgi.com/archives/xfs/2016-05/msg00347.html -- Jeff Bastian -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
