The $param can't be used for all command's options, for example
"help pwrite" include:
-Z N -- zeed the random number generator (used when writing randomly)
(heh, zorry, the -s/-S arguments were already in use in pwrite)
We should make param="-Z N", not only "-Z". After this patch, we can
run this function as:
_require_xfs_io_command pwrite -Z N
Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
---
Hi,
I did 2 changes in "[PATCH 1/2] common/rc: modify _require_xfs_io_command
function":
1. change "$command help" to "help $command"
2. change "param=$2" to "shift; param=\"$*\""
V2 patch give up the 1st change (Dave explained why we don't change that),
remain the 2nd change as below.
Thanks,
Zorro
common/rc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 51092a0..9c532cc 100644
--- a/common/rc
+++ b/common/rc
@@ -1874,7 +1874,8 @@ _require_xfs_io_command()
exit 1
fi
command=$1
- param=$2
+ shift
+ param="$*"
testfile=$TEST_DIR/$$.xfs_io
case $command in
--
2.5.5
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
