Re: [PATCH v4 2/3] xfstests: btrfs: test device replace, with EIO on the src dev

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]






So the test always fails due to a mismatch with this expected golden output:

     -Label: none  uuid: <UUID>
     +Label: none  uuid:  <UUID>
       Total devices <NUM> FS bytes used <SIZE>
       devid <DEVID> size <SIZE> used <SIZE> path SCRATCH_DEV
       devid <DEVID> size <SIZE> used <SIZE> path /dev/mapper/error-test

The extra space after "uuid:" comes from _filter_uuid:

    sed -e "s/\(uuid[ :=]\+\) *[0-9a-f-][0-9a-f-]*/\1 <UUID>/ig"

Which gets \1 with the string "uuid: " and then does "uuid: " + " " + "<UUID>".

We need to either to fix the golden output here or _filter_uuid (and
make sure it doesn't break any other tests using it directly or
indirectly such as yours).

commit a092363bbdfa6cc6e44353136bae9d3aa81baae2 (PATCH 3/3 V6] xfs: test changing UUID on V5 superblock) caused the regression. btrfs/006 is affected as well.

  Thanks
Anand
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux