fixes 9435b92 common: _require_command needs to handle parameters Also quoted $_command because _require_command may be called with an empty $1 parameter, e.g.: _require_command "$MY_UTIL_PROG" my_util # but $MY_UTIL_PROG is empty [ -x ] returns true. [ -x "" ] returns false, as required here. Signed-off-by: Omer Zilberberg <omzg@xxxxxxxxxxxxx> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> v2: address Eryu's comment regarding quotation --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rc b/common/rc index 6ea107e..68b07b8 100644 --- a/common/rc +++ b/common/rc @@ -1299,7 +1299,7 @@ _require_command() fi _command=`echo "$1" | awk '{ print $1 }'` - if [ ! -x $command ]; then + if [ ! -x "$_command" ]; then _notrun "$_name utility required, skipped this test" fi } -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html