On Thu, May 07, 2015 at 07:08:36PM +0300, Omer Zilberberg wrote:
> fixes 9435b92 common: _require_command needs to handle parameters
>
> Signed-off-by: Omer Zilberberg <omzg@xxxxxxxxxxxxx>
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 6ea107e..cd0f3e6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1299,7 +1299,7 @@ _require_command()
> fi
>
> _command=`echo "$1" | awk '{ print $1 }'`
> - if [ ! -x $command ]; then
> + if [ ! -x $_command ]; then
Can you please send v2 with $_command quoted? I found that if $_command
is empty -x still treats it as executable, but not empty quoted string.
# prints ok
if [ -x ]; then echo ok; fi
# prints nothing
if [ -x "" ]; then echo ok; fi
Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
