On Fri, Jan 09, 2015 at 03:52:45AM -0800, Jaegeuk Kim wrote: > This patch add the f2fs support for xfs/087 with goingdown. > xfs/087 is not really a test that should be made generic/shared; it's testing a bunch of different XFS specific mount options and log recovery behaviour which has no relevance to any other filesystem. If you want to take xfs specific tests that are only XFS specific because of the shutdowns they use, look at these ones: xfs/053 (data exposure) xfs/137 (data vs filesize) xfs/138 (data vs filesize vs truncate) xfs/139 (data vs filesize vs partial truncate) xfs/140 (data vs filesize vs extending truncate) xfs/179 (data vs filesize w/ fsync) xfs/180 (data vs filesize w/ sync) xfs/182 (data vs filesize w/ recovery) xfs/200 (recovery vs ro-block device) xfs/306 (fsstress vs recovery) These can all be made generic with very little effort - "_require_shutdown" is probably all that is necessary for most of them.... Also, we really are trying not to add more "shared" tests - with the correct "_requires_foo" rules we can just place those tests in generic/ and filesystems that don't support "foo" will avoid it. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
