Re: Patch: fix memory leak(spotted by Coverity)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch fixes multiple memory leaks in FcNameUnparseLangSet (Coverity
defect #1819).

-- 
Frederic Crozat <fcrozat@xxxxxxxxxxxx>
Mandriva
--- ChangeLog	11 Apr 2006 05:08:26 -0000	1.109.2.192
+++ ChangeLog	11 Apr 2006 12:07:01 -0000
@@ -1,3 +1,8 @@
+2006-04-11  Frederic Crozat  <fcrozat@xxxxxxxxxxxx>
+
+	* src/fclang.c: (FcNameUnparseLangSet):
+	Fix memory leak (Coverity defect #1819).
+
 2006-04-11  Behdad Esfahbod  <behdad@xxxxxxxxxxxxxx>
 	reviewed by: plam
 
Index: src/fclang.c
===================================================================
RCS file: /cvs/fontconfig/fontconfig/src/fclang.c,v
retrieving revision 1.14.4.10
diff -u -p -r1.14.4.10 fclang.c
--- src/fclang.c	7 Apr 2006 17:27:39 -0000	1.14.4.10
+++ src/fclang.c	11 Apr 2006 12:07:01 -0000
@@ -566,12 +566,17 @@
 	while ((extra = FcStrListNext (list)))
 	{
 	    if (!first)
-		if (!FcStrBufChar (buf, '|'))
+		if (!FcStrBufChar (buf, '|')) {
+                    FcStrListDone(list);
 		    return FcFalse;
-	    if (!FcStrBufString (buf, extra))
+		}
+	    if (!FcStrBufString (buf, extra)) {
+                FcStrListDone (list);
 		return FcFalse;
+	    }
 	    first = FcFalse;
 	}
+	FcStrListDone (list);
     }
     return FcTrue;
 }
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux