Hi,
I'm reviewing Coverity defect results on fontconfig
(http://scan.coverity.com/ ) to try to fix all defects for 2.3.95 (or at
least 2.4.0).
First patch fixes double free (and closing the same fd twice too).
I'll send other patches if needed while reviewing defects list.
--
Frederic Crozat <fcrozat@xxxxxxxxxxxx>
Mandriva
? fontconfig-2.3.92-fixcatcrash.patch
? fontconfig-2.3.92-fixlibxml.patch
? fontconfig-2.3.92-fixwarning.patch
? fontconfig-2.3.92.tar.bz2
? fontconfig-2.3.93-20060111.tar.bz2
? fontconfig-2.3.93-20060116.tar.bz2
? fontconfig-2.3.94-doublefree.patch
? fontconfig-fix-oldmanpage.patch
? fontconfig.fix
? fc-cache/stamp
Index: ChangeLog
===================================================================
RCS file: /cvs/fontconfig/fontconfig/ChangeLog,v
retrieving revision 1.109.2.185
diff -u -p -r1.109.2.185 ChangeLog
--- ChangeLog 7 Apr 2006 18:07:51 -0000 1.109.2.185
+++ ChangeLog 10 Apr 2006 11:53:12 -0000
@@ -1,3 +1,8 @@
+2006-04-10 Frederic Crozat <fcrozat@xxxxxxxxxxxx>
+
+ * src/fccache.c: (FcDirCacheWrite):
+ Fix double free (spotted by Coverity, CID #1965).
+
2006-04-07 Dominic Lachowicz <cinamod@xxxxxxxxxxx>
reviewed by: plam
* fc-cache/Makefile.am:
Index: src/fccache.c
===================================================================
RCS file: /cvs/fontconfig/fontconfig/src/fccache.c,v
retrieving revision 1.23.4.80
diff -u -p -r1.23.4.80 fccache.c
--- src/fccache.c 7 Apr 2006 04:42:32 -0000 1.23.4.80
+++ src/fccache.c 10 Apr 2006 11:53:12 -0000
@@ -1445,7 +1445,7 @@ FcDirCacheWrite (FcFontSet *set, FcStrSe
free (header);
close(fd);
if (!FcAtomicReplaceOrig(atomic))
- goto bail5;
+ goto bail3;
FcStrFree ((FcChar8 *)cache_hashed);
FcStrFree ((FcChar8 *)cache_file);
FcAtomicUnlock (atomic);
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig
