Re: Patch: fix memleak (spotted by Coverity)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch fixes memory leak in FcCacheWrite in bail cases (Coverity
report #1828).

-- 
Frederic Crozat <fcrozat@xxxxxxxxxxxx>
Mandriva
Index: ChangeLog
===================================================================
RCS file: /cvs/fontconfig/fontconfig/ChangeLog,v
retrieving revision 1.109.2.185
diff -u -p -r1.109.2.185 ChangeLog
--- ChangeLog	7 Apr 2006 18:07:51 -0000	1.109.2.185
+++ ChangeLog	10 Apr 2006 13:09:44 -0000
@@ -1,3 +1,8 @@
+2006-04-10  Frederic Crozat  <fcrozat@xxxxxxxxxxxx>
+
+	* src/fccache.c: (FcDirCacheWrite):
+	Fix memory leak when bail cases (Coverity defect #1828).
+
 2006-04-07  Dominic Lachowicz  <cinamod@xxxxxxxxxxx>
 	reviewed by: plam
 	* fc-cache/Makefile.am:
Index: src/fccfg.c
===================================================================
RCS file: /cvs/fontconfig/fontconfig/src/fccfg.c,v
retrieving revision 1.49.2.24
diff -u -p -r1.49.2.24 fccfg.c
--- src/fccfg.c	6 Feb 2006 19:25:45 -0000	1.49.2.24
+++ src/fccfg.c	10 Apr 2006 13:09:44 -0000
@@ -335,6 +335,7 @@
     
     return FcTrue;
 bail2:
+    FcGlobalCacheDestroy (cache);
     FcStrSetDestroy (oldDirs);
 bail1:
     FcFontSetDestroy (fonts);
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux