On May 31, 2022 / 19:01, Ankit Kumar wrote: > nvme-ns generic character devices currently do not support O_DIRECT flag. > Check for fio option for direct flag only if filetype is a block device. > > t/zbd skip test case #1 for character devices as they don't require > direct I/O. > > Tested-by: Vincent Fu <vincent.fu@xxxxxxxxxxx> > Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx> Thank you for fixing up. Looks good to me. Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> -- Shin'ichiro Kawasaki