> -----Original Message----- > From: Ankit Kumar [mailto:ankit.kumar@xxxxxxxxxxx] > Sent: Tuesday, May 31, 2022 9:32 AM > To: axboe@xxxxxxxxx > Cc: fio@xxxxxxxxxxxxxxx; krish.reddy@xxxxxxxxxxx; > joshi.k@xxxxxxxxxxx; anuj20.g@xxxxxxxxxxx; Ankit Kumar > <ankit.kumar@xxxxxxxxxxx>./test-zbd-support -l /dev/sg2 > Subject: [PATCH v3 7/9] zbd: Check for direct flag only if its block device > > nvme-ns generic character devices currently do not support O_DIRECT > flag. > Check for fio option for direct flag only if filetype is a block device. > > t/zbd skip test case #1 for character devices as they don't require > direct I/O. > > Tested-by: Vincent Fu <vincent.fu@xxxxxxxxxxx> > Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx> I ran t/zbd/run-tests-against-nullb and Test 1 ran for all sections. There were no test failures. I also created a zoned device with: modprobe scsi_debug zbc=2 zone_nr_conv=0 and then ran: t/zbd/test-zbd-support -l /dev/sg2 and all tests except Test 13 passed. The failure seems unrelated to this patch. The failure appears to be related to libzbc reporting max open zones incorrectly.