On 5/27/22 11:30 AM, Vincent Fu wrote: >> -----Original Message----- >> From: Ankit Kumar [mailto:ankit.kumar@xxxxxxxxxxx] >> Sent: Thursday, May 26, 2022 10:48 AM >> To: axboe@xxxxxxxxx >> Cc: fio@xxxxxxxxxxxxxxx; krish.reddy@xxxxxxxxxxx; >> joshi.k@xxxxxxxxxxx; anuj20.g@xxxxxxxxxxx >> Subject: [PATCH v2 8/8] examples: add 2 example job file for >> io_uring_cmd engine >> >> From: Anuj Gupta <anuj20.g@xxxxxxxxxxx> >> >> examples/uring-cmd-ng.fio has usage for conventional nvme-ns char >> device >> examples/uring-cmd-zoned.fio has usage for ZNS nvme-ns char device >> >> Signed-off-by: Anuj Gupta <anuj20.g@xxxxxxxxxxx> >> Co-authored-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx> >> --- > > A minor nit: consider putting ioengine=io_uring_cmd and cmd_type=nvme > directly in the job file. Seconded - mixed job files generally only make sense for some kind of testing framework, the example job files should be runnable directly without using any args of environment variables. -- Jens Axboe
