On 2021/11/23 23:27, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@xxxxxxx>
>
> The name for add_lat_percentile_sample() is confusing, since the function
> actually adds a per priority percentile sample (it also adds a regular
> sample), yet it doesn't have prio as part of the function name.
>
> Rename the function so that it is more obvious that this function should
> be used if you want to add a prio percentile sample.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> ---
> stat.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/stat.c b/stat.c
> index 44ca3894..f5d5cd24 100644
> --- a/stat.c
> +++ b/stat.c
> @@ -3061,9 +3061,10 @@ static void add_lat_percentile_sample_noprio(struct thread_stat *ts,
> ts->io_u_plat[lat][ddir][idx]++;
> }
>
> -static void add_lat_percentile_sample(struct thread_stat *ts,
> - unsigned long long nsec, enum fio_ddir ddir,
> - bool high_prio, enum fio_lat lat)
> +static void add_lat_percentile_prio_sample(struct thread_stat *ts,
> + unsigned long long nsec,
> + enum fio_ddir ddir,
> + bool high_prio, enum fio_lat lat)
> {
> unsigned int idx = plat_val_to_idx(nsec);
>
> @@ -3119,7 +3120,8 @@ void add_clat_sample(struct thread_data *td, enum fio_ddir ddir,
> if (ts->lat_percentiles)
> add_lat_percentile_sample_noprio(ts, nsec, ddir, FIO_CLAT);
> else
> - add_lat_percentile_sample(ts, nsec, ddir, high_prio, FIO_CLAT);
> + add_lat_percentile_prio_sample(ts, nsec, ddir, high_prio,
> + FIO_CLAT);
> }
>
> if (iolog && iolog->hist_msec) {
> @@ -3220,7 +3222,8 @@ void add_lat_sample(struct thread_data *td, enum fio_ddir ddir,
> * sample when lat_percentiles=0).
> */
> if (ts->lat_percentiles) {
> - add_lat_percentile_sample(ts, nsec, ddir, high_prio, FIO_LAT);
> + add_lat_percentile_prio_sample(ts, nsec, ddir, high_prio,
> + FIO_LAT);
> if (high_prio)
> add_stat_sample(&ts->clat_high_prio_stat[ddir], nsec);
> else
>
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
