> -----Original Message-----
> From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> Sent: Sunday, February 14, 2021 2:17 PM
> To: axboe@xxxxxxxxx
> Cc: fio@xxxxxxxxxxxxxxx
> Subject: [PATCH] fio: simplify zoneskip= validness check
fio: -> zbd:?
>
> Simply check the remainder
>
> (zoneskip % zone_size) > 0
>
> It will do the right thing for all zoneskip= values, and
> zonesize being positive is checked earlier.
>
> Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@xxxxxxxxx>
With the small nit above, looks good.
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
> ---
>
> zbd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- a/zbd.c
> +++ b/zbd.c
> @@ -285,9 +285,7 @@ static bool zbd_verify_sizes(void)
> return false;
> }
>
> - if (td->o.zone_skip &&
> - (td->o.zone_skip < td->o.zone_size ||
> - td->o.zone_skip % td->o.zone_size)) {
> + if (td->o.zone_skip % td->o.zone_size) {
> log_err("%s: zoneskip %llu is not a multiple of
> the device zone size %llu.\n",
> f->file_name, (unsigned long long)
> td->o.zone_skip,
> (unsigned long long) td-
> >o.zone_size);
