On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote:
> From: Aravind Ramesh <aravind.ramesh@xxxxxxx>
>
> Based on the flag enable_check_swd, which is false by default, fio
> does not initialize the swd value at startup, initializing the swd
> value to be zero, even if some zones have sectors with data. This can
> result in fio reflecting less than actual swd after a few writes are
> completed. In workloads where verify is enabled, fio resets all the
> zones and while resetting, it decrements the swd counter with the
> actual number of swds in that zone(swd-count - swd-in-zone),
> since swd-count is initialized to 0, it results in overflow of the
> variable causing unpredictable issues.
>
> So, initialize the swd to the correct value.
>
> Fixes: 409a4f291e7f ("zbd: avoid initializing swd when unnecessary")
> Signed-off-by: Aravind Ramesh <aravind.ramesh@xxxxxxx>
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
--
Best Regards,
Shin'ichiro Kawasaki
