On Jan 07, 2021 / 06:57, Dmitry Fomichev wrote:
> zbd_adjust_block() always returns with the zone locked if the i/o is
> accepted. The corresponding unlock happens in zbd_put_io(). The
> function description says -
>
> * Locking strategy: returns with z->mutex locked if and only if z refers
> * to a sequential zone and if io_u_accept is returned. z is the zone that
> * corresponds to io_u->offset at the end of this function.
>
> Remove the recently added unlock after zbd_replay_write_order() call.
> Add a Coverity annotation to mark the absence of unlock as intentional.
>
> Fixes: b2726d53bb5d ("zbd: Add a missing pthread_mutex_unlock() call")
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
--
Best Regards,
Shin'ichiro Kawasaki
