On 5/22/20 12:27 PM, Elliott, Robert (Servers) wrote: > >>> Fundamentally, this argument needs to support larger than >>> 32-bit values. Persistent memory devices easily exceed that >>> bandwidth too. >>> >>> Other arguments like "size" already take large values into an >>> unsigned long long. So, just changing this for "rate" and >>> "rate_min" might suffice: >>> .type = FIO_OPT_INT, >>> to >>> .type = FIO_OPT_STR_VAL, >> >> Yup but there are two issues here: >> >> 1. (This bug report) The range handling of all FIO_OPT_INT arguments >> is broken. >> >> 2. rate (and min_rate) should support values bigger than 4G. >> >> I am working on a PR/patch for item 2 [1]. Looking for guidance on >> item 1. >> > > Should at least item 2 go into 3.20? Should already be in the repo. -- Jens Axboe
