Re: [BUG] parse.c: val_too_large incorrectly handling overly large FIO_OPT_INT values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert

> Fundamentally, this argument needs to support larger than
>    32-bit values. Persistent memory devices easily exceed that
>    bandwidth too.
>
>    Other arguments like "size" already take large values into an
>    unsigned long long. So, just changing this for "rate" and
>    "rate_min" might suffice:
>                    .type   = FIO_OPT_INT,
>    to
>                    .type   = FIO_OPT_STR_VAL,

Yup but there are two issues here:

1. (This bug report) The range handling of all FIO_OPT_INT arguments is broken.

2. rate (and min_rate) should support values bigger than 4G. 

I am working on a PR/patch for item 2 [1]. Looking for guidance on item 1.

Cheers
 
Stephen

[1]: https://github.com/axboe/fio/issues/716





[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux