On 4/9/20 4:41 PM, Damien Le Moal wrote:
> On 2020/04/10 2:14, Alexey Dobriyan wrote:
>> On Thu, Apr 09, 2020 at 01:58:13AM +0000, Damien Le Moal wrote:
>>> On 2020/04/09 7:16, Alexey Dobriyan wrote:
>>>> Sequential write with max_open_zones=1 has interesting (read: buggy)
>>>> interaction with verify=.
>>
>>>> + if (f->zbd_info->open_zones[i] == nz) {
>>>> + zbd_close_zone(td, f, i);
>>>> + }
>>>
>>> nit: you do not need the {} brackets for the if here.
>>
>> I started to use {} everywhere, it is less thinking that way.
>
> Sure, but that is not the coding style normally used in fio and many other open
> source C projects. I will let Jens decide here.
I prefer no braces for single lines. The exception is if/else, where if one
has braces, the rest should too. Fio isn't really consistent in the latter
I think, but definitely the former.
--
Jens Axboe
