Re: [PATCH] zbd: fix sequential verify with max_open_zones=1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 09, 2020 at 01:58:13AM +0000, Damien Le Moal wrote:
> On 2020/04/09 7:16, Alexey Dobriyan wrote:
> > Sequential write with max_open_zones=1 has interesting (read: buggy)
> > interaction with verify=.

> > +				if (f->zbd_info->open_zones[i] == nz) {
> > +					zbd_close_zone(td, f, i);
> > +				}
> 
> nit: you do not need the {} brackets for the if here.

I started to use {} everywhere, it is less thinking that way.

> With the nits above fixed, this looks OK to me.
> 
> It would be good to add a test case for this to t/zbd/test-zbd-support. Can you
> send something please ?

I'll try. This needs a test with blktrace parsing and eveything.



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux