Thanks a lot for fix and apply. 😊 -----Original Message----- From: Jens Axboe <axboe@xxxxxxxxx> Sent: Wednesday, January 22, 2020 11:32 PM To: Su, Friendy <Friendy.Su@xxxxxxxx>; Sitsofe Wheeler <sitsofe@xxxxxxxxx> Cc: fio <fio@xxxxxxxxxxxxxxx>; Kobayashi, Kento (Sony) <Kento.A.Kobayashi@xxxxxxxx> Subject: Re: [PATCH] engines: add engine for file stat On 1/21/20 8:07 PM, Su, Friendy wrote: > This engine is to measure performance of accessing file's meta data. > This is for the actual access pattern which does not do real IO, but > just look up the file and get file's attribute. Applied, just one minor fixup: > + if (f->filetype != FIO_TYPE_FILE) { > + log_err("fio: only files are supported fallocate \n"); > + return 1; > + } Not sure where this fallocate came from, too much copy paste perhaps? -- Jens Axboe