On 12/29/19 2:23 PM, Sitsofe Wheeler wrote: > On Thu, 19 Dec 2019 at 10:20, Su, Friendy <Friendy.Su@xxxxxxxx> wrote: >> >> Thanks for your comments. >> I fixed and resent patch. Pls see my reply in text below. > > From a brief scan it looks OK to me but I'd say you are better off > posting patches in-line because it make review easier (anyone else who > wants to see it will have to look at the parent of this mail). If this > is troublesome you can always try submitting a pull request (e.g. via > https://github.com/axboe/fio/pulls )... > > Jens: If you can see the patch as an attachment (e.g. at the bottom of > https://www.spinics.net/lists/fio/msg08203.html ), what do you think? With my io_uring hat on, there's a few ways to do stat since io_uring also supports it. Is the plan to enable a io_uring backend as well for that engine? Or should stat perhaps be a data direction instead that all io engines could then support, some of them in an async manner? -- Jens Axboe
