Thanks. I will send patch again. -----Original Message----- From: Jens Axboe <axboe@xxxxxxxxx> Sent: Tuesday, January 21, 2020 11:27 PM To: Su, Friendy <Friendy.Su@xxxxxxxx>; Sitsofe Wheeler <sitsofe@xxxxxxxxx> Cc: fio <fio@xxxxxxxxxxxxxxx>; Kobayashi, Kento (Sony) <Kento.A.Kobayashi@xxxxxxxx> Subject: Re: [PATCH] engines: add engine for file stat I'm not totally against adding this type of engine, I just think that going forward it'd be better to make any sort of file oriented operation something the IO engine can perform, instead of having a specific engine for that. But that's probably a larger scope project than you're willing to attack, and I don't think it'd be fair to gate the inclusion of this one on that. So feel free to send the latest version you have and we can take a look at it. On 1/21/20 3:09 AM, Su, Friendy wrote: > Any update or opinion on this topic? > > -----Original Message----- > From: Su, Friendy > Sent: Wednesday, January 8, 2020 5:33 PM > To: Jens Axboe <axboe@xxxxxxxxx>; Sitsofe Wheeler <sitsofe@xxxxxxxxx> > Cc: fio <fio@xxxxxxxxxxxxxxx>; Kobayashi, Kento (Sony) > <Kento.A.Kobayashi@xxxxxxxx> > Subject: RE: [PATCH] engines: add engine for file stat > > Sorry, I resend patch in mail body, not attachment. > > Until now, I have not considered relation between 'io_uring' and 'filestat'. > > This 'filestat' engine is created since under some real occasion, we really care about 'how fast files being lookup or operated' as well as 'how fast read/write'. FIO is strong on 'IO performance' measurement, we choose FIO. We want the same benchmark tool to measure 'file operation' since 'same tool' makes condition, sequence easy to be same. Based on this, I created 'filestat' engine. We hope FIO can be strengthen its capability on 'file operation' measurement. Besides 'filestat', 'file-delete', 'file-rename' are also need. > > -----Original Message----- > From: Jens Axboe <axboe@xxxxxxxxx> > Sent: Monday, December 30, 2019 7:21 AM > To: Sitsofe Wheeler <sitsofe@xxxxxxxxx>; Su, Friendy > <Friendy.Su@xxxxxxxx> > Cc: fio <fio@xxxxxxxxxxxxxxx>; Kobayashi, Kento (Sony) > <Kento.A.Kobayashi@xxxxxxxx> > Subject: Re: [PATCH] engines: add engine for file stat > > On 12/29/19 2:23 PM, Sitsofe Wheeler wrote: >> On Thu, 19 Dec 2019 at 10:20, Su, Friendy <Friendy.Su@xxxxxxxx> wrote: >>> >>> Thanks for your comments. >>> I fixed and resent patch. Pls see my reply in text below. >> >> From a brief scan it looks OK to me but I'd say you are better off >> posting patches in-line because it make review easier (anyone else >> who wants to see it will have to look at the parent of this mail). If >> this is troublesome you can always try submitting a pull request >> (e.g. via https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_axboe_fio_pulls&d=DwICaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=x4w-xeFLV1q9QNvT-g51hIN_YdnTDh2iniRTDjOpGTk&m=n7aH04Az0Bke6LtP1bcGhKisgjZ4-_cX3Cm0aJyo62Y&s=HZGFwGTEsbbO6oWDd2fNQYzft3kP9Yv1DBiBq7dmDj0&e= )... >> >> Jens: If you can see the patch as an attachment (e.g. at the bottom >> of https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_fio_msg08203.html&d=DwICaQ&c=fP4tf--1dS0biCFlB0saz0I0kjO5v7-GLPtvShAo4cc&r=x4w-xeFLV1q9QNvT-g51hIN_YdnTDh2iniRTDjOpGTk&m=n7aH04Az0Bke6LtP1bcGhKisgjZ4-_cX3Cm0aJyo62Y&s=gVr4lkUJChqpKsxpSPdguu8txoH_geku7Z5MQXzYK_k&e= ), what do you think? > > With my io_uring hat on, there's a few ways to do stat since io_uring also supports it. Is the plan to enable a io_uring backend as well for that engine? Or should stat perhaps be a data direction instead that all io engines could then support, some of them in an async manner? > > > -- > Jens Axboe > -- Jens Axboe
