On 7/31/19 2:57 PM, vincentfu@xxxxxxxxx wrote: > From: Vincent Fu <vincent.fu@xxxxxxx> > > firstfree() triggers a warning from the Windows compiler used by > AppVeyor because it doesn't return a value if the for loop iterates to > completion. This patch resolves the compiler warning. > > AppVeyor Windows build log: https://ci.appveyor.com/project/axboe/fio/builds/26381726 I did this on top, as it removes the need to have that weird assert() with a return. Also fixes the coding style (mix of tabs and spaces), and makes it easier to read imho. Please review! http://git.kernel.dk/cgit/fio/commit/?id=21eabccd000aaa36ff8af2cd0db833e0871ed85b -- Jens Axboe