On 7/31/19 2:57 PM, vincentfu@xxxxxxxxx wrote: > From: Vincent Fu <vincent.fu@xxxxxxx> > > firstfree() triggers a warning from the Windows compiler used by > AppVeyor because it doesn't return a value if the for loop iterates to > completion. This patch resolves the compiler warning. > > AppVeyor Windows build log: https://ci.appveyor.com/project/axboe/fio/builds/26381726 > --- > smalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/smalloc.c b/smalloc.c > index c97bcbaa..0d7054a4 100644 > --- a/smalloc.c > +++ b/smalloc.c > @@ -347,6 +347,9 @@ static unsigned int firstfree(struct pool *pool) > return i; > > assert(0); > + > + /* we will never get here but this fixes a compiler warning */ > + return -1U; > } Thanks, a bit ugly (for Windows), but no big deal. -- Jens Axboe
