Re: [PATCH] bssplit: Fix handling of 0 percentage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/30/19 10:32 PM, Damien Le Moal wrote:
> If a block size percentage is ispecified as 0 in bssplit, the block size
> defined is not ignored by the loop in get_next_buflen(). In particular,
> if the first (smallest) block size specified has a 0 percentage, the
> loop is existed and that block size used as the next IO size, resulting
> in a behavior equivalent to specifying 100%. E.g. using
> --bssplit=64k/0,1024k/100 results in 100% of issued IOs to be 64KB
> instead of 1MB.
> 
> Fix this by ignoring bssplit entries that have a 0 percentage. This is
> safe as the initialization of the bssplit array ensure that the sum of
> all percentages is always 100, guaranteeing that a block size will be
> chosen for the next IO size.

Applied, thanks Damien.

-- 
Jens Axboe




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux