On 7/12/18 4:13 PM, Jeff Furlong wrote:
>> Right, it's just converting (if needed) the general case to be ull based
> I added a FIO_OPT_ULL case and made the maxval appropriate there.
> diff --git a/parse.c b/parse.c
> index 6261fca..d125ffc 100644
> --- a/parse.c
> +++ b/parse.c
> @@ -615,25 +617,25 @@ static int __handle_option(const struct fio_option *o, const char *ptr,
> if (fn)
> ret = fn(data, &ull);
> else {
> - if (o->type == FIO_OPT_INT) {
> + if ((o->type == FIO_OPT_INT) || (o->type == FIO_OPT_ULL)) {
> if (first)
> - val_store(ilp, ull, o->off1, 0, data, o);
> + val_store(ullp, ull, o->off1, 0, data, o);
This isn't going to work, as FIO_OPT_INT will be an integer pointer, not
a pointer to an unsigned long long. The above will overwrite nearby
members.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
