Re: [PATCH] Fix overflow in percentile calculation for Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12 October 2017 at 06:28, Andrzej Jakowski
<andrzej.jakowski@xxxxxxxxx> wrote:
> On Wed, Oct 11, 2017 at 4:36 PM, Vincent Fu <vincentfu@xxxxxxxxx> wrote:
>> Andrzej, does this actually resolve the problem you observed? unsigned long
>> nr in the parameter list of calc_clat_percentiles() and
>> show_clat_percentiles() also looks like it will overflow when you have more
>> than 2^32 IOs.
> Yes you are right. That original patch is not sufficient. Will get it
> fixed and post new version soon.

I've got a feeling there are few other 32 bit platform integer
overflows lurking around. I'm trying a clang sanitizer run...

-- 
Sitsofe | http://sucs.org/~sits/
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux