Re: [PATCH] Fix overflow in percentile calculation for Windows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jens,

On 10 October 2017 at 22:27, Andrzej Jakowski
<andrzej.jakowski@xxxxxxxxx> wrote:
> This patch fixes percentile calculation for Windows where overflow
> on 32 bit type happened while calculating actual percentiles.
>
> Signed-off-by: Andrzej Jakowski <andrzej.jakowski@xxxxxxxxx>
> ---
>  stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stat.c b/stat.c
> index c5a68ad5..5c758680 100644
> --- a/stat.c
> +++ b/stat.c
> @@ -139,7 +139,7 @@ unsigned int calc_clat_percentiles(unsigned int *io_u_plat, unsigned long nr,
>                                    fio_fp64_t *plist, unsigned long long **output,
>                                    unsigned long long *maxv, unsigned long long *minv)
>  {
> -       unsigned long sum = 0;
> +       unsigned long long sum = 0;
>         unsigned int len, i, j = 0;
>         unsigned int oval_len = 0;
>         unsigned long long *ovals = NULL;
> --
> 2.13.6

Just in case you didn't see it, the above looks sensible/necessary...

-- 
Sitsofe | http://sucs.org/~sits/
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux