On 09/18/2017 11:53 AM, kusumi.tomohiro@xxxxxxxxx wrote:
> From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
>
> This lets platforms without dio (e.g. OpenBSD) fail with an explicit
> message, otherwise they fail without a clue about dio even with
> --debug=all enabled.
>
> "if (!OS_O_DIRECT)" is needed so that only platforms without both
> O_DIRECT and FIO_OS_DIRECTIO print this message if/when called.
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
> ---
> filesetup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/filesetup.c b/filesetup.c
> index b51ab35..c5eb7cf 100644
> --- a/filesetup.c
> +++ b/filesetup.c
> @@ -1868,6 +1868,8 @@ int fio_set_directio(struct thread_data *td, struct fio_file *f)
>
> return 0;
> #else
> + if (!OS_O_DIRECT)
> + log_err("fio: the file system does not seem to support direct IO\n");
> return -1;
> #endif
Does that need the OS_O_DIRECT check? We know that FIO_OS_DIRECTIO isn't
set at that point, that should be enough.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
