On 27 July 2017 at 21:44, Jens Axboe <axboe@xxxxxxxxx> wrote:
> On 07/27/2017 02:38 PM, kusumi.tomohiro@xxxxxxxxx wrote:
>> From: Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxx>
>>
>> log_err(ENOSYS) on native_fallocate() failure which was newly added
>> by 2c3e17be('filesetup: add native fallocate') should be silenced
>> or somehow be printed only once instead of being a per file message.
>>
>> This happens on a platform like FreeBSD where posix_fallocate(3)
>> exists, but native_fallocate() is ENOSYS.
>>
>> This commit just silences it if errno is set to ENOSYS on return.
>> "native" is the default mode, thus not printing ENOSYS won't be any
>> confusing unless fallocate=native is explicitly specified, and
>> native_fallocate() has dprint() for ENOSYS case anyway.
>
> I think that's the right fix, ENOSYS is expected for some setups,
> so it need not be a visible error.
I wonder if the default actually be set to "none" on all systems that
don't implement a native fallocate regardless of whether they
implement posix_fallocate?
--
Sitsofe | http://sucs.org/~sits/
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
