Re: [PATCH] don't print native_fallocate() error if ENOSYS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/27/2017 02:38 PM, kusumi.tomohiro@xxxxxxxxx wrote:
> From: Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxx>
> 
> log_err(ENOSYS) on native_fallocate() failure which was newly added
> by 2c3e17be('filesetup: add native fallocate') should be silenced
> or somehow be printed only once instead of being a per file message.
> 
> This happens on a platform like FreeBSD where posix_fallocate(3)
> exists, but native_fallocate() is ENOSYS.
> 
> This commit just silences it if errno is set to ENOSYS on return.
> "native" is the default mode, thus not printing ENOSYS won't be any
> confusing unless fallocate=native is explicitly specified, and
> native_fallocate() has dprint() for ENOSYS case anyway.

I think that's the right fix, ENOSYS is expected for some setups,
so it need not be a visible error.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux