On Tue, Mar 21, 2017 at 8:51 PM, Jens Axboe <axboe@xxxxxx> wrote: > On 03/21/2017 05:16 PM, Gwendal Grignou wrote: >> So far, fio key names use '_' instead of ' '. >> Fix keys with 'job options' and 'global options' to match the naming >> convention. > > Is there a problem with the outputted json? No the json file is correct, and it is acceptable to have spaces in keys. > I agree it would be > cleaner to have the underscore instead of the space, but this > change might also break scripts that parse the existing > output. So we need a good reason to change it, which isn't > just a cosmetic concern. Most cosmetic: the spaces were breaking a script around older version of fio, but it is a script issue, no a fio issue. > > Just curious what your motivations are for the change. > I understand it is too late to change fio, so ignore the patch. > -- > Jens Axboe > -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
