On 02/14/2017 08:27 AM, Tomohiro Kusumi wrote: > I couldn't see a race too, but assumed there is since you (the author) say so. > For the other one in dup_files(), I didn't think there's any race as commented. > > But yes, if there's no race, please drop this. OK good, then I'll just drop it. BTW, for reference, this was the original code: if (__f) { /* * racy, need the __f->lock locked */ f->lock = __f->lock; f->lock_owner = __f->lock_owner; f->lock_batch = __f->lock_batch; f->lock_ddir = __f->lock_ddir; [...] where that comment was from. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html