I couldn't see a race too, but assumed there is since you (the author) say so. For the other one in dup_files(), I didn't think there's any race as commented. But yes, if there's no race, please drop this. 2017-02-14 17:23 GMT+02:00 Jens Axboe <axboe@xxxxxxxxx>: > On Tue, Feb 14 2017, kusumi.tomohiro@xxxxxxxxx wrote: >> From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx> >> >> to the destination file pointer. >> The ones in dup_files() doesn't seem to require locking from >> the way it's been called. > > I've been thinking about this a little bit, since I could not see what > the race was. Do you spot one, or are you just acting on the comment? > I think the original race was that we copied over the lock, lock owner, > batch, etc. Hence the race was that if someone else grabbed the lock > while we were doing that copy, the fields weren't in a consistent state. > But now we're just copying the pointer to the lock, so I don't think > there's a race. It's just a stale comment. > > -- > Jens Axboe > -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
