Scramble buffers not set by default unless set explicitly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A change (1bf2498d311155bc4eb43edb4e6d3a04845d94c5) to make scramble buffers easier to understand appears to have made scramble buffers not the default behavior by accident.  The logic would always evaluate such that scramble buffers is not used unless set explicitly.

I think the following little patch changes the logic to what was intended.

diff --git a/init.c b/init.c
index 427768c..a47186b 100644
--- a/init.c
+++ b/init.c
@@ -937,7 +937,7 @@ static void init_flags(struct thread_data *td)
         * set. But if scramble_buffers has been set, always scramble.
         */
        if (o->scramble_buffers && ((!o->zero_buffers &&
-           fio_option_is_set(o, zero_buffers)) ||
+           !fio_option_is_set(o, zero_buffers)) ||
            fio_option_is_set(o, scramble_buffers)))
                td->flags |= TD_F_SCRAMBLE_BUFFERS;
        if (o->verify != VERIFY_NONE)
----
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux