On 09/04/2013 07:56 AM, Erwan Velu wrote: > On 04/09/2013 00:37, Jens Axboe wrote: >> It should work, if it doesn't, I agree it's a bug. It's not certain >> than anyone has considered this specific use case before. Feel free to >> fix! Or I can take a look at it tomorrow. > I think I found the issue but my main question is about priority. > > If both time & loops are set, what shall be considered as the key > element to stop the benchmark. > > Today, time have the priority over loops as keep_running() returns if > time_based while time is handled in do_io(). > > If I do remove this test in keep_running, the first of the two getting > the limit will stop the job. > On one hand, we have timebased option to insure time over end of device. > Shall we put a loopbased on the other hand ? Good point, yes, that is a problem. Adding a loopbased option would seem to be the best way to solve the dependency issue. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
