Re: --minimal does not work in client/server mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/29/2013 10:00 AM, asomers@xxxxxxxxx wrote:
> I found a few more things that need to be suppressed in terse mode.
> The updated patch is here.  In addition to working with JSON output,
> we also need to check that the patch doesn't break disk statistics.  I
> haven't tried using those at all yet.
> 
> https://gist.github.com/asomers/6105396

I would suggest making a show_thread_status_all() that does something ala:

void show_thread_status_all()
{
   if (is_backend)
       fio_server_send_ts(ts, rs);
   else if (output_format == FIO_OUTPUT_TERSE)
       show_thread_status_terse(ts, rs);
   else if (output_format == FIO_OUTPUT_JSON) {
       struct json_object *tmp = show_thread_status_json(ts, rs);

       json_array_add_value_object(array, tmp);
   } else
       show_thread_status(ts, rs);
}

which should work for all. If you could check and fix the json bit too,
bonus points, and I'll test and commit it. Thanks!


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux