On Sun, Apr 14 2013, Aaron Carroll wrote: > On 14 April 2013 04:05, Jens Axboe <axboe@xxxxxxxxx> wrote: > > On Sat, Apr 13 2013, Aaron Carroll wrote: > >> On 12 April 2013 18:04, Jens Axboe <axboe@xxxxxxxxx> wrote: > >> > On Fri, Apr 12 2013, Aaron Carroll wrote: > >> >> s pointer from integer without a > >> >> > cast [enabled by default] > >> >> > cgroup.c:46:2: warning: implicit declaration of function 'endmntent' > >> >> > [-Wimplicit-function-declaration] > >> >> > cgroup.c: At top level: > >> >> > cgroup.c:78:6: error: redefinition of 'cgroup_kill' > >> >> > cgroup.h:24:20: note: previous definition of 'cgroup_kill' was here > >> >> > cgroup.c:147:5: error: redefinition of 'cgroup_setup' > >> >> > cgroup.h:13:19: note: previous definition of 'cgroup_setup' was here > >> >> > cgroup.c:189:6: error: redefinition of 'cgroup_shutdown' > >> >> > cgroup.h:20:20: note: previous definition of 'cgroup_shutdown' was here > >> >> > make: *** [cgroup.o] Error 1 > >> >> > >> >> What compiler generates that? As I said I'm now getting clean builds > >> >> for Android. > >> > > >> > I grabbed the 32-bit NDK from the page you referenced. > >> > >> I'm using that exact NDK and don't get that error. Weird. > > > > What about the mntent related ones? Looking at mntent.h in > > sysroot/usr/include/, it contains: > > [..] > > So bits missing... The cgroup stuff I didn't look at. You are using the > > 32-bit variant as well, not the 64-bit one? > > Hi Jens, > > Yes, 32-bit NDK generated with arch=x86 platform=android-14. > Something seems weird with your build... cgroup.c should not be > compiled at all for Android. > > $ git pull > $ make clean > $ make CROSS_COMPILE=~/dev/android-toolchains-r8e/x86-4.6/bin/i686-linux-android- That works for me. Perhaps a small paragraph in the README under the Building section mentioning how to build for android would be a good idea? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
