On 2012-03-01 20:23, Daniel Ehrenberg wrote: > On Thu, Mar 1, 2012 at 6:41 AM, Jens Axboe <axboe@xxxxxxxxx> wrote: >> On 02/29/2012 10:22 PM, Daniel Ehrenberg wrote: >>> Hi, >>> >>> I'd just like to clarify: I'm not sure if the patch I just sent is >>> exactly what we'd want. Maybe it is correct to set FIO_HAVE_FALLOCATE >>> on some Linux systems which aren't at least glibc version 2.8. I don't >>> know much about the history of these features, and if any fio users >>> are using an older system where they do still want fallocate >>> capabilities, I'd appreciate input here. >> >> There is something a bit wonky there. We should be able to use >> posix_fallocate() from 2.6 and on, but only the linux fallocate from 2.8 >> and up. >> >> Something like the below. >> >> diff --git a/os/os-linux.h b/os/os-linux.h >> index 3bf6bd9..d5c3f76 100644 >> --- a/os/os-linux.h >> +++ b/os/os-linux.h >> @@ -50,6 +50,9 @@ >> * Can only enable this for newer glibcs, or the header and defines are >> * missing >> */ >> +#if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 6 >> +#define FIO_HAVE_FALLOCATE >> +#endif >> #if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 8 >> #define FIO_HAVE_LINUX_FALLOCATE >> #endif >> >> -- >> Jens Axboe >> > > That looks good to me. Thanks for the revision. Thanks for letting me know. The change has been committed. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe fio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
