Re: [PATCH] fallocate: enable fallocate options on Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I'd just like to clarify: I'm not sure if the patch I just sent is
exactly what we'd want. Maybe it is correct to set FIO_HAVE_FALLOCATE
on some Linux systems which aren't at least glibc version 2.8. I don't
know much about the history of these features, and if any fio users
are using an older system where they do still want fallocate
capabilities, I'd appreciate input here.

Thanks,
Dan

On Wed, Feb 29, 2012 at 12:54 PM, Dan Ehrenberg <dehrenberg@xxxxxxxxxx> wrote:
> Simple bug fix to ensure that fallocate-related options are
> once again enabled on Linux systems with the right headers present.
> A previous patch gated the FIO_HAVE_LINUX_FALLOCATE flag on
> header versions but failed to enable FIO_HAVE_FALLOCATE in this
> case.
> ---
>  os/os-linux.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/os/os-linux.h b/os/os-linux.h
> index 3bf6bd9..b911753 100644
> --- a/os/os-linux.h
> +++ b/os/os-linux.h
> @@ -51,6 +51,7 @@
>  * missing
>  */
>  #if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 8
> +#define FIO_HAVE_FALLOCATE
>  #define FIO_HAVE_LINUX_FALLOCATE
>  #endif
>
> --
> 1.7.7.3
>
--
To unsubscribe from this list: send the line "unsubscribe fio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux